Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the project’s type-checking workflow from Pyright to Astral’s ty, aligning dev dependencies, lint commands, and editor recommendations with the new toolchain.
Changes:
- Replace
pyrightwithtyin dev dependencies and update thejust lintcommand to runty check. - Remove the Pyright configuration and re-enable Ruff’s unused-code checks by no longer ignoring
F401/F841. - Update VS Code extension recommendations from Pylance to the
tyextension and simplify the CLI entrypoint to avoid an unusedargsbinding.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Removes pyright (and nodeenv) and adds locked ty artifacts. |
src/moelib/__main__.py |
Removes the unused args assignment after parse_args(). |
pyproject.toml |
Swaps Pyright for ty in dev deps, removes [tool.pyright], and re-enables Ruff unused-code rules. |
justfile |
Updates lint to run uv run ty check ... instead of Pyright. |
.vscode/extensions.json |
Recommends astral-sh.ty instead of Pylance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SigureMo
commented
Apr 25, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs: yutto-dev/yutto#619